properly escape quotes in passwords by calling to_python #361
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
database passwords can contain special characters, especially " and ' so we can't just print the value of the field enclosed by single quotes as that would break whenever the user uses a literal ' in their password
bastelfreak
reviewed
Oct 16, 2024
| @@ -24,7 +24,7 @@ DATABASES = { | |||
| 'ENGINE': 'django.db.backends.postgresql', | |||
| 'NAME': '<%= scope['pulpcore::postgresql_db_name'] %>', | |||
| 'USER': '<%= scope['pulpcore::postgresql_db_user'] %>', | |||
| 'PASSWORD': '<%= scope['pulpcore::postgresql_db_password'] %>', | |||
| 'PASSWORD': <%= scope.call_function('to_python', [scope['pulpcore::postgresql_db_password']]) %>, | |||
There was a problem hiding this comment.
is that the function from stdlib? Then maybe use the new namespaced version?
Suggested change
| 'PASSWORD': <%= scope.call_function('to_python', [scope['pulpcore::postgresql_db_password']]) %>, | |
| 'PASSWORD': <%= scope.call_function('stdlib::to_python', [scope['pulpcore::postgresql_db_password']]) %>, |
There was a problem hiding this comment.
it is, the rest of the file is not using the namespaced version, so I didn't want to diverge
bastelfreak
approved these changes
Oct 16, 2024
ekohl
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
database passwords can contain special characters, especially " and '
so we can't just print the value of the field enclosed by single quotes
as that would break whenever the user uses a literal ' in their password